Skip to content

setup assisted-installer version v2.55 - #83609

Closed
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-0a36350a-4294-4460-82df-2505db79f0ba
Closed

setup assisted-installer version v2.55#83609
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-0a36350a-4294-4460-82df-2505db79f0ba

Conversation

@danmanor

@danmanor danmanor commented Aug 18, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Updates the Assisted Installer v2.55 CI jobs in assisted-installer-agent and assisted-installer.
  • Prevents subsystem-test and e2e-metal-assisted jobs from running unconditionally.
  • Uses pipeline_skip_if_only_changed for change-based job skipping.

@danmanor danmanor mentioned this pull request Aug 18, 2026
Closed
@coderabbitai

coderabbitai Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a1bbb839-d1a5-42a7-88b9-fd728437a2ee

📥 Commits

Reviewing files that changed from the base of the PR and between 5c70d21 and e996608.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.

Walkthrough

The Assisted Installer test configurations now disable unconditional execution and use pipeline_skip_if_only_changed for file-change-based skipping.

Changes

Assisted Installer skip behavior

Layer / File(s) Summary
Configure pipeline-level test skipping
ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml, ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml		 The subsystem-test and e2e-metal-assisted jobs set always_run: false. Their file-change exclusions move from skip_if_only_changed to pipeline_skip_if_only_changed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e9966

This PR makes localized CI configuration updates with no identified correctness or deployment risk; it is merge-ready after normal checks.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the assisted-installer v2.55 setup, which matches the pull request changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only CI YAML scheduling fields and generated annotations; it introduces no Ginkgo It, Describe, Context, or When titles, dynamic values, or test-name strings.
Test Structure And Quality ✅ Passed The parent-to-PR diff changes only CI YAML job/config files; it adds no Ginkgo It blocks, cluster operations, waits, or assertions for this check to assess.
Microshift Test Compatibility ✅ Passed The PR changes only four CI YAML files for job skipping and annotations; the diff adds no Ginkgo tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR diff changes only CI configuration and generated Prow YAML; it adds no Ginkgo tests or test declarations, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The diff changes only CI test skip settings and generated presubmit annotations; it adds no deployment, operator, controller, or OpenShift workload scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The diff changes only CI YAML scheduling and generated job annotations; it adds no OTE binary or process-level code, so it introduces no stdout contract violation.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only CI YAML and generated Prow job metadata; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto ✅ Passed The diff only changes CI job scheduling fields; no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, crypto code, or secret comparisons were added.
Container-Privileges ✅ Passed The PR changes only job skip annotations and always_run settings; the added diff contains no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The diff only changes test scheduling fields and generated annotations; it adds no commands, logging statements, or sensitive values.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

openshift-merge-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-subsystem-test openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted openshift/assisted-installer presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
openshift-ci Bot requested review from jhernand and pastequo August 18, 2026 15:45
@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2026
@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danmanor

danmanor commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #83675

@danmanor danmanor closed this Aug 19, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Aug 19, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhernand jhernand Awaiting requested review from jhernand
@pastequo pastequo Awaiting requested review from pastequo

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danmanor @openshift-edge-bot